Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@faker-js/faker
was included with all of its locales in the front production build, which made it 11 MB ungzipped and 7.69 MB gzipped, taking up to 5.13 MB (66.7 % of the whole bundle size).react-scripts was compiling using
tsconfig.json
, which included test files, the mock API for frontend tests, etc. Typescript compilation was removed and replaced by a manual step beforereact-scripts build
, usingtsconfig.build.json
.Also,
@zerologementvacant/models
was split between@zerologementvacant/models
(shared types) and@zerologementvacant/models/fixtures
(shared factories for DTO types, for test purposes).The resulting production bundle does not include
@faker-js/faker
from the build, as intended, which reduces its size down to 2.55 MB ungzipped, 530 KB gzipped.